Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fishbowl's generation of helper functions #9

Open
t92549 opened this issue Aug 11, 2022 · 1 comment
Open

Improve fishbowl's generation of helper functions #9

t92549 opened this issue Aug 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@t92549
Copy link
Contributor

t92549 commented Aug 11, 2022

As described in #8, a lot of gafferpy classes have "helper functions", that effectively wrap some inputs for the user to make gafferpy easier to use.
With fishbowl's addition into gafferpy, a lot of these were lost and needed to be added back manually.
However, fishbowl could use the type of a parameter to generate helper functions.

For example, where the operation details endpoint states the input parameter has:
"className": "uk.gov.gchq.gaffer.data.element.Element[]"
This could automatically wrap a single Element into a list, and even wrap single values in EntitySeeds.

As well as this, Element's properties could be wrapped in types depending on the schema.

@t92549
Copy link
Contributor Author

t92549 commented May 26, 2023

Another example of this is GetElementsBetweenSetsPairs (see docs).

Once this has been updated, we should update the docs.

@t92549 t92549 transferred this issue from gchq/gaffer-tools Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant