Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not build on riscv64 #127

Closed
nmeum opened this issue Jul 10, 2021 · 4 comments
Closed

Does not build on riscv64 #127

nmeum opened this issue Jul 10, 2021 · 4 comments

Comments

@nmeum
Copy link

nmeum commented Jul 10, 2021

Hi, I just wanted to let you know that termshark does not build on riscv64 by default. This is due to following issues:

  1. github.com/kr/pty does not support riscv64. However, the repository is a fork and archived. The original version github.com/creack/pty does support riscv64. Maybe switch to that?
  2. Similar to arm64, the dup2 syscall is not available on riscv64. You can just use dup3 as set the last argument (the flags argument) to zero. This is equivalent to dup2. There should be no need for a custom DumpcapExt implementation for arm64/riscv64 IMHO.
algitbot pushed a commit to alpinelinux/aports that referenced this issue Jul 10, 2021
@nmeum
testing/termshark: fix build on riscv64
db159f0 
* Requires newer version of the pty module.
* Use dup3 instead of dup2.

See gcla/termshark#127
@gcla
Copy link
Owner

gcla commented Jul 10, 2021

Thanks for the report @nmeum , I'll look into this.

@qbit
Copy link

qbit commented Jul 27, 2021

fwiw, the creack/pty also will allow termshark to build on OpenBSD/armv7,arm64 (and mips64 once creack/pty#123 lands).

gcla added a commit that referenced this issue Jul 30, 2021
@gcla
Use latest gowid for updated pty library
feea76b 
I'm doing this because creack/pty has support for more combinations of
OSes and architectures - this is motivated by termshark issue #127.
gcla added a commit that referenced this issue Jul 30, 2021
@gcla
Rearrange the dup() functions to compile on more platforms
cdfed14 
This fixes issue #127. Thanks @nmeum for the suggestion - this should
provide a path forward for more OSes and architectures.
@gcla
Copy link
Owner

gcla commented Jul 30, 2021

Thanks @nmeum and @qbit - please let me know if the master branch needs more work for your needs.

@gcla
Copy link
Owner

gcla commented Aug 20, 2021

I'll close this for now because I think it's resolved on master - but please re-open if it's not resolved.

@gcla gcla closed this as completed Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gcla @qbit @nmeum