Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question and answer activity #230

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Question and answer activity #230

wants to merge 2 commits into from

Conversation

amitsagtani97
Copy link
Contributor

Todo:
Fix layouts for vertical mode.
Create admin mode.
Task -- > https://phabricator.kde.org/T5469

@amitsagtani97
question_and_answer, activity initialization
a8c504a
@amitsagtani97
Implemented freeMode
fdf0140 
Todo:
Fix layout for vertical mode.
Implement adminMode.
petitlapin
petitlapin reviewed Aug 12, 2018
View reviewed changes
src/activities/question_and_answer/ActivityInfo.qml
author: "Amit Sagtani <asagtani06@gmail.com>"
demo: true
//: Activity title
title: "Question_and_answer activity"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no underscore in title, use a real name (that will be displayed on screen)

src/activities/question_and_answer/ActivityInfo.qml
title: "Question_and_answer activity"
//: Help title
description: ""
//intro: "put here in comment the text for the intro voice"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be updated

@AkshayCHD
Copy link
Contributor

@amitsagtani97 Hii, can i complete this activity, it would be helpful if you could just let me know what are the things left to implement here.

@amitsagtani97
Copy link
Contributor Author

@AkshayCHD Hi, sure you can complete it.
Here is the link to the task -- https://phabricator.kde.org/T5469
Here is the link to the google doc, which I proposed for this activity -- https://docs.google.com/document/d/1tzA5r0nsBfPoBjYl81a0qTsVt6aHnP_KfcB1CmPIrfE/edit?usp=sharing

I have implemented the Menu Screen and added two sub-activities.
The overall layout needs to be improved for vertical screens and an admin mode needs to be implemented as discussed in the proposal.
Feel free to ask in case of any doubt :)

@AkshayCHD
Copy link
Contributor

@amitsagtani97 hii, i wanted to ask, in admin mode we have to allow the user to choose the questions on his own, right?

@amitsagtani97
Copy link
Contributor Author

@AkshayCHD In admin mode, we can select the questions to be asked.
This allows tutors to create different sets of questions for the kids to solve and practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petitlapin petitlapin petitlapin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitsagtani97 @AkshayCHD @petitlapin