Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lean into bang-bang convention #92

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Lean into bang-bang convention #92

merged 2 commits into from
Mar 24, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Mar 24, 2024

Core

  • Accept the bang-bang convention fully: mutation may never happen
  • Make pushforward!!/pullback!! depend on pushforward/pullback
  • Change jacobian!! to make sure we write back into the column with the results. Wrote this part with a manual loop because copyto! allocates for array views
  • Move things around in core files

Docs

  • Reinsert "preparation" section

Tests

  • Fix title of correctness tests that said call count
  • Remove mutation tests

Extensions

  • Remove useless code for out-of-place backends
  • Add experimental Taped.jl support

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.33333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 91.67%. Comparing base (e2e04ae) to head (a54d60d).

Files Patch % Lines
...erfaceTapedExt/DifferentiationInterfaceTapedExt.jl 0.00% 7 Missing ⚠️
src/jacobian.jl 92.30% 4 Missing ⚠️
src/DifferentiationTest/printing.jl 0.00% 1 Missing ⚠️
src/DifferentiationTest/test_operators.jl 0.00% 1 Missing ⚠️
src/backends.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   92.59%   91.67%   -0.93%     
==========================================
  Files          49       50       +1     
  Lines        1243     1201      -42     
==========================================
- Hits         1151     1101      -50     
- Misses         92      100       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 224f8cf into main Mar 24, 2024
2 checks passed
@gdalle gdalle deleted the gd/bangbang branch March 24, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants