Lost a key event once when exiting or suspending in v2.2.1.

[noborus]

For example, _demos/mouse.go.
It didn't finish until I pressed the ESC key twice and then pressed any key (or moving the mouse cursor)
(same for suspend).

The cause is that a read block occurs in the inputLoop of tscreen.go.

func (t *tScreen) inputLoop(stopQ chan struct{}) {

	defer t.wg.Done()
	for {
		select {
		case <-stopQ:
			return
		default:
		}
		chunk := make([]byte, 128)
		n, e := t.in.Read(chunk)        // <------ block

(In v2.2.0, it was os.Stdin, so it could be finished.)
I'm trying on Linux (Ubuntu).

[gdamore]

Argh. There is no way to win. Some want /dev/tty. But that has warts like this. I may go back to stdin and give an alternative api for the few folks who don’t agree with that approach. Get Outlook<https://aka.ms/qtex0l> for iOS

…

________________________________ From: Noboru Saito ***@***.***> Sent: Sunday, April 25, 2021 8:33:34 AM To: gdamore/tcell ***@***.***> Cc: Subscribed ***@***.***> Subject: [gdamore/tcell] Lost a key event once when exiting or suspending in v2.2.1. (#452) For example, _demos/mouse.go. It didn't finish until I pressed the ESC key twice and then pressed any key (or moving the mouse cursor) (same for suspend). The cause is that a read block occurs in the inputLoop of tscreen.go. func (t *tScreen) inputLoop(stopQ chan struct{}) { defer t.wg.Done() for { select { case <-stopQ: return default: } chunk := make([]byte, 128) n, e := t.in.Read(chunk) // <------ block (In v2.2.0, it was os.Stdin, so it could be finished.) I'm trying on Linux (Ubuntu). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#452>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJ4G7OWU2SLK4QBIYHUGL3TKQY45ANCNFSM43RMRHCA>.

[gdamore]

Please see the tty branch for a possible fix.

[noborus]

Thank you very much.
It works fine in my environment.