Add API to allow creating Screen using custom terminfo as well as custom tty. #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
custom terminfo as well as custom tty.
iamtakingiteasy
force-pushed
the
master
branch
from
01d1e80 to
37ccae3
Compare
iamtakingiteasy
changed the title
|
yes, I can see how this would be useful -- thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup to #148 -- currently
NewTerminfoScreenFromTtystill uses local OS environment to get the terminfo and there is no public API to override it.This PR adds such API, in form of
NewTerminfoScreenFromTtyTerminfothat also accepts terminfo instanceLookupTerminfothat exposes current name-to-terminfo lookup procedureWhile
NewTerminfoScreenFromTtystill defeaults toLookupTerminfowith $TERM contents to maintain backwards compatability.