Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find module dataverse-design-system #281

Closed
pdurbin opened this issue May 12, 2023 · 0 comments · Fixed by #282
Closed

Cannot find module dataverse-design-system #281

pdurbin opened this issue May 12, 2023 · 0 comments · Fixed by #282

Comments

@pdurbin
Copy link
Member

pdurbin commented May 12, 2023

We're seeing the following error at https://jenkins.dataverse.org/job/IQSS-dataverse-develop/1340/consoleFull

TASK [dataverse : npm run build] ***********************************************
fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["npm", "run", "build", "--", "--base=/spa"], "delta": "0:00:13.852793", "end": "2023-05-12 19:13:50.745822", "msg": "non-zero return code", "rc": 2, "start": "2023-05-12 19:13:36.893029", "stderr": "", "stderr_lines": [], "stdout": "\n> dataverse-frontend@0.1.0 build\n> tsc && vite build --base=/spa\n\nsrc/index.tsx(6,31): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations.\nsrc/sections/layout/Layout.tsx(2,27): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations.\nsrc/sections/layout/footer/Footer.tsx(1,37): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations.\nsrc/sections/layout/header/Header.tsx(3,24): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations.\ntests/support/commands.tsx(40,31): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations.", "stdout_lines": ["", "> dataverse-frontend@0.1.0 build", "> tsc && vite build --base=/spa", "", "src/index.tsx(6,31): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations.", "src/sections/layout/Layout.tsx(2,27): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations.", "src/sections/layout/footer/Footer.tsx(1,37): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations.", "src/sections/layout/header/Header.tsx(3,24): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations.", "tests/support/commands.tsx(40,31): error TS2307: Cannot find module 'dataverse-design-system' or its corresponding type declarations."]}

This PR was merged yesterday...

... and its description includes some steps that I think are relevant:

1. Build the module

`npm run install`

`cd packages/design-system`

`npm run build`

2. Use the module in the main application

Go back to the root `dataverse-frontend/`

`npm run start`

That is to say, I think we need to teach Ansible to separately build that new "dataverse-design-system" module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant