Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for tables in Markdown previewer #76

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

added support for tables in Markdown previewer #76

wants to merge 2 commits into from

Conversation

ErykKul
Copy link

@ErykKul ErykKul commented Jul 9, 2024

Added option to allow tables in Markdown previewer.

Closes #71

pdurbin
pdurbin approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice simple fix and comments from users on #71 indicate there's interest.

I haven't tested it but I'm approving this.

@pdurbin pdurbin mentioned this pull request Oct 1, 2024
Open
@pdurbin
Copy link
Member

pdurbin commented Oct 1, 2024

Would this also close the following issue?

@ErykKul
Copy link
Author

ErykKul commented Oct 2, 2024

I think so. The example I made with a table after applying the fix (with the table at the bottom):

image

The example is the readme file from here: https://github.com/gdcc/dataverse-exporters
The table got bigger, but the concepts are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdurbin pdurbin pdurbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tables in Markdown previewer
2 participants
@ErykKul @pdurbin