Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for default namespace overwritten by empty namespace #241

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

bumann-sbb
Copy link

Fixes #240

Fix for default namespace overwritten by empty namespace
Fixed a few SonarLint warnings

@bumann-sbb
Copy link
Author

@pdurbin Now the pipeline throws following, which seems like something I can't fix or am I missing something?

Error:  Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.11.0.3922:sonar 
(default-cli) on project xoai: Project not found. 
Please check the 'sonar.projectKey' and 'sonar.organization' properties, 
the 'SONAR_TOKEN' environment variable, or contact the project administrator to check the permissions 
of the user the token belongs to -> [Help 1]

@pdurbin
Copy link
Member

pdurbin commented Sep 11, 2024

@bumann-sbb yikes. Probably not.

I wonder... is it because the workflow only works properly under the main repo (gdcc) and not in a fork (such as bumann-sbb).

@poikilotherm any thoughts on this? And the PR overall. 😄

Copy link
Member

@poikilotherm poikilotherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a fix for pre-commit and some restyling in the test.

Well done! Thanks for also adding a test case! Perfect PR. Will merge and cut a release soon!

(Don't worry about SonarCloud. As this is a PR from a fork, you don't get access to the secrets necessary to commit the results.)

@poikilotherm poikilotherm merged commit 1802351 into gdcc:branch-5.0 Sep 12, 2024
@bumann-sbb
Copy link
Author

bumann-sbb commented Sep 13, 2024

@pdurbin @poikilotherm
Thank you both very much. It was a pleasure to contribute! :)

@bumann-sbb bumann-sbb deleted the issue-240 branch September 13, 2024 11:46
@poikilotherm
Copy link
Member

Thanks for your contribution! Even with a unit test! That's how Open Source is meant to be. ❤️

@pdurbin pdurbin added this to the 5.2.2 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty namespaces on attributes overwriting the default namespace
3 participants