Added error handling if resumption token is not a valid base64 string #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build apparently does not work because I'm working on a fork. |
|
Yes, apparently so. I opened an issue about this: |
|
Any updates on this? Is there a different way I can contribute to avoid this error? |
|
@bumann-sbb no, you're doing everything right. We've just been busy! 😅 Thanks for your patience! |
- Use a parameterized test with format.parse(), not the lower level API call, making it more aligned to the pre-existing tests. - Add a parsing test with a string that contains UTF-8 chars to ensure encoding and decoding those works and don't provoke failures.
poikilotherm
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Hi @bumann-sbb !
Thanks for the PR, good catch! 🫶
I refactored the test a bit and will merge now. After I merged some of the open PRs by Renovate bot, I'm going to cut a 5.2.2 release, should be available soon. You can obviously already test using the 5.2.2-SNAPSHOT.
Cheers!
|
5.2.2 has been released, should be available soon from Central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending an invalid resumption token (not a valid base64 encoded String) the library throws an unhandled exception (
IllegalArgumentException).This change handles this exception and throws a
BadResumptionTokenExceptionand thus produces a valid OAI PMH response.