Fixes scroll TOP/BOTTOM scrolling #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EsmaeelNabil
force-pushed
the
droidcon/esmaeel-fix-scroll-to-top
branch
2 times, most recently
from
9be617c
to
83d7188
Compare
EsmaeelNabil
changed the title
|
Ktlint check is failing, could you check that please? |
Fixes scroll to the top by - using the device actual screen height instead of a hardcoded value
EsmaeelNabil
force-pushed
the
droidcon/esmaeel-fix-scroll-to-top
branch
from
83d7188
to
fe83018
Compare
louis993546
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot/Gif
scroll-fix.mp4