Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Migration] Android hilt to koin #410

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Migration] Android hilt to koin #410

wants to merge 2 commits into from

Conversation

oianmol
Copy link

@oianmol oianmol commented Aug 14, 2024 •
edited
Loading

Summary

This PR deals with the migration from Hilt to Koin
Introduced jvmToolchain and bumped to JDK 17

How It Was Tested

  1. The app when executed runs fine.
  2. I have executed android:check and all the unit tests were passing
  3. RoborazziTest.kt had to be updated for some issue on my device when running tests.
  4. Fixed a VM test where a mock was missing. (I would like to get rid of all the mocks TBH maybe next PR ?)
  5. GenerateBaselineProfiles was attempted but failed with uiAutomator not being able to find a view.

Screenshot/Gif

Screenshot Name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oianmol