Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

add docs for letsencrypt SSL cert with nginx proxy #117

Merged
merged 3 commits into from
Mar 26, 2017

Conversation

VikramTiwari
Copy link
Member

@VikramTiwari VikramTiwari commented Mar 21, 2017

For #98

@VikramTiwari VikramTiwari self-assigned this Mar 21, 2017
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nitpicks, thank you!

sudo ln -s /etc/nginx/sites-available/subsites /etc/nginx/sites-enabled/subsites
```

- get a cert using LetsEncrypt (Make sure LetsEncrypt is installed)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Can you please add a link to instructions for installing Let's Encrypt? I know that there are various different NodeJS and platform specific packages/libs.

## in the file
ssl_certificate /etc/letsencrypt/live/hub.gdgx.io/fullchain.pem;
ssl_certificate_key /etc/letsencrypt/live/hub.gdgx.io/privkey.pem;
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this into two blocks? One for the command one for the file contents.


## in the file
# from https://cipherli.st/
# and https://raymii.org/s/tutorials/Strong_SSL_Security_On_nginx.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this into two blocks? One for the command one for the file contents.

- add letsencrypt setup docs
- update nginx setup
@VikramTiwari
Copy link
Member Author

@Splaktar Fixed and added some more docs.

@Splaktar
Copy link
Contributor

Awesome, can you link to the letsencrypt doc from the nginx-setup doc please?

Once we get it merged, I'll link to the docs from the wiki.

@VikramTiwari
Copy link
Member Author

@Splaktar Done! They should be auto-linked internally and you will need to create a link from wiki.

@Splaktar Splaktar added this to the v0.3.0 milestone Mar 26, 2017
@Splaktar
Copy link
Contributor

Thank you very much!

@Splaktar Splaktar merged commit 34e5ad8 into develop Mar 26, 2017
@Splaktar Splaktar deleted the feature/vikram/ssl_docs branch March 26, 2017 04:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants