-
Notifications
You must be signed in to change notification settings - Fork 19
add docs for letsencrypt SSL cert with nginx proxy #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks, thank you!
docs/nginx-setup.md
Outdated
sudo ln -s /etc/nginx/sites-available/subsites /etc/nginx/sites-enabled/subsites | ||
``` | ||
|
||
- get a cert using LetsEncrypt (Make sure LetsEncrypt is installed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Can you please add a link to instructions for installing Let's Encrypt? I know that there are various different NodeJS and platform specific packages/libs.
docs/nginx-setup.md
Outdated
## in the file | ||
ssl_certificate /etc/letsencrypt/live/hub.gdgx.io/fullchain.pem; | ||
ssl_certificate_key /etc/letsencrypt/live/hub.gdgx.io/privkey.pem; | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split this into two blocks? One for the command one for the file contents.
docs/nginx-setup.md
Outdated
|
||
## in the file | ||
# from https://cipherli.st/ | ||
# and https://raymii.org/s/tutorials/Strong_SSL_Security_On_nginx.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split this into two blocks? One for the command one for the file contents.
- add letsencrypt setup docs - update nginx setup
@Splaktar Fixed and added some more docs. |
Awesome, can you link to the letsencrypt doc from the nginx-setup doc please? Once we get it merged, I'll link to the docs from the wiki. |
@Splaktar Done! They should be auto-linked internally and you will need to create a link from wiki. |
Thank you very much! |
For #98