Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build dark css #26

Merged
merged 3 commits into from
Jan 14, 2025
Merged

fix build dark css #26

merged 3 commits into from
Jan 14, 2025

Conversation

giufus
Copy link
Collaborator

@giufus giufus commented Jan 14, 2025

provo la stessa PR non da fork per vedere se era un problema di permessi...

@Zavy86
Copy link
Member

Zavy86 commented Jan 14, 2025

direi che funziona.. :D

@Zavy86
Copy link
Member

Zavy86 commented Jan 14, 2025

ma mi chiedo come tu abbia fatto a pushare questo file visto che era nel .gitignore..

static/style.css

@inalto è normale che quel file sia ancora presente nella repository, l'ultimo touch risulta sulla tua PR #20

https://github.com/gdgvda/tech-pizza-delivery-waiter/blob/main/static/style.css

@giufus
Copy link
Collaborator Author

giufus commented Jan 14, 2025

Era tracked prima della modifica su .gitignore

@Zavy86
Copy link
Member

Zavy86 commented Jan 14, 2025

sospettavo.. quindi in teoria se lo rimuoviamo forzatamente dovrebbe poi ricrearlo dinamicamente in fase di build?

"build": "tsc && tailwindcss -i ./src/css/style.css -o ./static/style.css && cp -rp ./src/views ./dist",

@giufus provi tu a fare un commit con il remove del file?

@giufus
Copy link
Collaborator Author

giufus commented Jan 14, 2025

Si, mi piace pensare che potrebbe funzionare:)

git rm --cached filebalordo.css

mi pare, e poi nuovo commit

@Zavy86
Copy link
Member

Zavy86 commented Jan 14, 2025

proviamo! ho bumpato io

@Zavy86 Zavy86 merged commit a9462b9 into main Jan 14, 2025
1 check passed
@Zavy86 Zavy86 deleted the feature/dark-mode branch January 14, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants