reorder events for click: enter?+down+focus+up+click

This fixes a bug that some node may find they are `"focus"`ed twice.

E.g. http://<gogs>:3123/repo/create
* the framework semantic-ui allow both `focus` and `click` events to show a popup menu
* if `focus` occurs before a `mousedown`, then it thinks the event is made by a `tab` key
* or it does nothing on `focus`

content/dom_ui.js

@@ -95,9 +95,15 @@ VDom.UI = {
     sel.removeAllRanges();
     return true;
   },
+  click: function(element, modifiers, addFocus) {
+    element === VDom.lastHovered || VDom.unhoverLast(element, modifiers);
+    VDom.mouse(element, "mousedown", modifiers);
+    addFocus && element !== VEventMode.lock() && element.focus();
+    VDom.mouse(element, "mouseup", modifiers);
+    VDom.mouse(element, "click", modifiers);
+  },
   simulateSelect: function(element, flash, suppressRepeated) {
-    element.focus();
-    VDom.simulateClick(element);
+    this.click(element, null, true);
     flash === true && this.flash(element);
     if (element !== VEventMode.lock()) { return; }
     var len;

content/frontend.js

@@ -605,7 +605,7 @@ var VSettings, VHUD, VPort, VEventMode;
     }
     linkElement.scrollIntoViewIfNeeded();
     VDom.UI.flash(linkElement);
-    setTimeout(function() { VDom.simulateClick(linkElement); }, 0);
+    setTimeout(function() { VDom.UI.click(linkElement); }, 0);
     return true;
   },
   goBy: function(relName, pattern) {

content/link_hints.js

@@ -820,7 +820,7 @@ LEAVE: {
   129: "Simulate mouse leaving link",
   193: "Simulate mouse leaving continuously",
   activator: function(element) {
-    VDom.simulateMouse(element, "mouseout");
+    VDom.mouse(element, "mouseout");
     if (document.activeElement === element) { element.blur(); }
   }
 },
@@ -963,7 +963,7 @@ DOWNLOAD_LINK: {
     if (oldDownload == null) {
       link.download = "";
     }
-    VDom.simulateClick(link, {
+    VDom.UI.click(link, {
       altKey: true,
       ctrlKey: false,
       metaKey: false,
@@ -1011,19 +1011,18 @@ DEFAULT: {
       VDom.UI.simulateSelect(link, true);
       return false;
     }
-    if (mode > 0 || link.tabIndex >= 0) { link.focus(); }
     mode = this.mode & 3;
     if (mode >= 2 && tag === "a") {
       alterTarget = link.getAttribute('target');
       link.target = "_top";
     }
     // NOTE: not clear last hovered item, for that it may be a menu
-    VDom.simulateClick(link, {
+    VDom.UI.click(link, {
       altKey: false,
       ctrlKey: mode >= 2 && !onMac,
       metaKey: mode >= 2 &&  onMac,
       shiftKey: mode === 3
-    });
+    }, mode > 0 || link.tabIndex >= 0);
     if (alterTarget === undefined) {}
     else if (alterTarget === null) {
       link.removeAttribute("target");

lib/dom_utils.js

@@ -203,33 +203,25 @@ var VDom = {
     for (o = el; o && o.nodeType !== eTy; o = o.previousSibling) {}
     return o || (el && el.parentNode);
   },
-  simulateMouse: function(element, type, modifiers, related) {
+  mouse: function(element, type, modifiers, related) {
     var mouseEvent = document.createEvent("MouseEvents");
     modifiers || (modifiers = this.defaultMouseKeys);
     mouseEvent.initMouseEvent(type, true, true, window, 1, 0, 0, 0, 0
       , modifiers.ctrlKey, modifiers.altKey, modifiers.shiftKey, modifiers.metaKey
       , 0, related || null);
     return element.dispatchEvent(mouseEvent);
   },
-  _eventSequence: ["click", "mouseup", "mousedown"],
   defaultMouseKeys: { altKey: false, ctrlKey: false, metaKey: false, shiftKey: false },
   lastHovered: null,
   unhoverLast: function(newEl, modifiers) {
     var last = this.lastHovered;
     if (last && this.isInDOM(last)) {
-      this.simulateMouse(last, "mouseout", modifiers, newEl !== last ? newEl : null);
+      this.mouse(last, "mouseout", modifiers, newEl !== last ? newEl : null);
     } else {
       last = null;
     }
     this.lastHovered = newEl;
-    newEl && this.simulateMouse(newEl, "mouseover", modifiers, last);
-  },
-  simulateClick: function(element, modifiers) {
-    var eventSequence = this._eventSequence, _i;
-    element === this.lastHovered || this.unhoverLast(element, modifiers);
-    for (_i = eventSequence.length; 0 <= --_i; ) {
-      this.simulateMouse(element, eventSequence[_i], modifiers);
-    }
+    newEl && this.mouse(newEl, "mouseover", modifiers, last);
   }
 },
 

pages/show.js

@@ -171,7 +171,7 @@ function clickLink(options, event) {
   }
   a.href = url;
   if (window.VDom) {
-    VDom.simulateClick(a, event);
+    VDom.UI.click(a, event);
   } else {
     a.click();
   }