Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vomnibar no longer working for file:// URLs #1021

Closed
zeke-jeske opened this issue Oct 24, 2023 · 8 comments
Closed

Vomnibar no longer working for file:// URLs #1021

zeke-jeske opened this issue Oct 24, 2023 · 8 comments

Comments

@zeke-jeske
Copy link

Describe the bug

In the last two weeks, the Vomnibar stopped working for me when opening filesystem URLs in browser, e.g. file:///Users/myuser/downloads/my-document.pdf. Whether I type the entire URL into the Vomnibar or select it from the list of suggestions, when I press enter to open the URL the Vomnibar closes and nothing happens.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a page where the Vomnibar works, like this one.
  2. Press O, o, B, or b to open the Vomnibar.
  3. Type in a URL for a local file beginning with file:/// or select one from the list of suggestions below the input field.
  4. Press enter.

Browser, OS and Vimium C versions

  • Browser name: Google Chrome
  • Browser version: 118.0.5993.88
  • Vimium C version: 1.99.99
  • OS name and version: macOS Sonoma v14.0 on a 14-inch 2021 MacBook Pro with an M1
@zeke-jeske zeke-jeske changed the title Vomnibar no longer working for file:// URLs Vomnibar no longer working for file:// URLs Oct 24, 2023
@gdh1995
Copy link
Owner

gdh1995 commented Nov 12, 2023

Not reproduced on my Chrome 118 + macOS. Have you seen this problem again in the recent week?

If Vomnibar can show on a local HTML file, or a local folder page like file:///, then I guess your problem is because your keyboard focus is grabbed by Chrome's built-in PDF Viewer, so Vimium C can not receive your shortcut keys.

@zeke-jeske
Copy link
Author

zeke-jeske commented Nov 13, 2023

Yep, I'm still getting this problem. It happens with HTML files, PDF files, images, anything. Prior to a few weeks ago, this has always worked, so I don't think it's an issue with keyboard focus.

Here's a screen recording.

@gdh1995
Copy link
Owner

gdh1995 commented Nov 14, 2023 via email

@zeke-jeske
Copy link
Author

Web links can't go from a non-local website to a local file, so link hints aren't relevant to this issue. If I have a file:// URL on my clipboard, p or P does not work to open it. If I use ge and replace the current URL with a file:// URL, it also doesn't work (nothing happens).

My best guess is that Chrome has some security feature that's preventing extensions from opening local files, but you would know more about this than me.

@zeke-jeske
Copy link
Author

Wait! I figured it out! Chrome has now added an option in the extension's options page to "Allow access to file URLs", and it is disabled by default. Enabling this makes Vimium C work again. This change was initiated in Chrome v. 118.

Screenshot 2023-11-14 at 1 18 51 PM

@Gattocrucco
Copy link

I have the same problem in Firefox.

I could not find how to make it work though. There is no per-extension option for allowing local files like in Chrome.

@zeke-jeske
Copy link
Author

@Gattocrucco Try this

@zeke-jeske zeke-jeske reopened this Jan 15, 2024
@Gattocrucco
Copy link

It works, thanks!

I thought that kind of thing could only disable the security feature globally, but ostensibly it just does it for Vimium-C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants