clear button for Input & SearchInput #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve issue #32 .
Hello, this is my first contribution to an elm project. I did run the tests for chrome which passed (firefox seems not yet supported - missing geckodriver ? In my firefox tests mostly everything failed). Also, I wasn't sure which branch this PR to target for so I just used master.
The clear button works like that: it only appears if there is text and the input is not readonly or disabled.
Very good project structure, was very nice to work with. I would also try to resolve further issues.
Greetings