Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #93 #97

Closed
wants to merge 1 commit into from
Closed

fix issue #93 #97

wants to merge 1 commit into from

Conversation

aniketkuma-r
Copy link

footer social icons overlapping fix. #93

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Aniket3063! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Keep being the part of the community!

'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'

@pooranjoyb pooranjoyb added enhancement New feature or request good first issue Good for newcomers hacktoberfest Label for Hacktoberfest hacktoberfest-accepted Accepted PR for Hacktoberfest bugfix A bug is fixed labels Oct 24, 2023
Copy link
Collaborator

@pooranjoyb pooranjoyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see any specific changes regarding bug-fix or some Change in CSS.
Please mention the changes you made. @aniketkuma-r

@aniketkuma-r
Copy link
Author

the issue has already been fixed in #88 by someone else. but some how changes are not reflected on the hosted website. the CSS was already working fine in local setup at my localhost:5173/contact there is nothing to change in CSS. code is fine I have checked all the code properly.
I guess there is problem with gh-pages or something with hosting platform that why changes are not reflected even after PR got merged.

@aniketkuma-r
Copy link
Author

I agree there is no significant change in my code but still I tried to refactor the code quality to some extinct. as the issue was already resolved but not reflected in website. i can't do any change from my end in the code to fix in hosted website as CSS is already fine. and working fine in local setup.

@pooranjoyb
Copy link
Collaborator

Got it @aniketkuma-r 👍
Thanks for clarification. Actually I haven't updated the build in the gh-pages as some bugs were found.
So, as this the issue is fixed. I'll close it then. Hope you find some more issues to work on :)

@pooranjoyb pooranjoyb closed this Oct 24, 2023
@pooranjoyb pooranjoyb removed the hacktoberfest-accepted Accepted PR for Hacktoberfest label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A bug is fixed enhancement New feature or request good first issue Good for newcomers hacktoberfest Label for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants