Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show DRC Results Database (.lyrdb) file in KLayout #6

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

lukasc-ubc
Copy link
Contributor

The purpose is to extend KLive functionality so that not only can you send the GDS file to KLayout for viewing, but you can also send the DRC or Functional Verification results for viewing.

This adds an extra optional argument "lyrdb_filename", which is the file to show.

show(file_gds,lyrdb_filename=file_lyrdb)

An example is shown here: https://github.com/SiEPIC/SiEPIC-Tools/blob/master/klayout_dot_config/python/SiEPIC/utils/klive.py

image

Copy link
Collaborator

@sebastian-goeldi sebastian-goeldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the version numbers in the PR, they are managed by tbump.

@sebastian-goeldi
Copy link
Collaborator

sebastian-goeldi commented Nov 19, 2023

I will check it out today when I have a bit more time later. When building this into klive, I think it would also make sense to add the ability to load l2n files.

Is it ok if I use this branch?

@lukasc-ubc
Copy link
Contributor Author

give me a second to make sure it works after I make these edits.

@lukasc-ubc
Copy link
Contributor Author

Ok. Ready.

@lukasc-ubc
Copy link
Contributor Author

Hi @sebastian-goeldi

The pull request is ready for you to merge.

Adding l2n is a good idea for the future.

thank you
Lukas

@sebastian-goeldi sebastian-goeldi merged commit 5033d66 into gdsfactory:main Nov 20, 2023
@lukasc-ubc
Copy link
Contributor Author

Thanks Sebastian. I just demonstrated this in the CMC SiEPIC-Passives workshop.

Will you release this on the salt package manager? Incidentally, have you figured out a way to make it easy to update packages on salt, or do you do it manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants