Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest gdsfactory version #146

Merged
merged 9 commits into from
Jan 1, 2023
Merged

update to latest gdsfactory version #146

merged 9 commits into from
Jan 1, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jan 1, 2023

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 1, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.57%.

Quality metrics Before After Change
Complexity 0.82 ⭐ 1.73 ⭐ 0.91 👎
Method Length 38.11 ⭐ 38.40 ⭐ 0.29 👎
Working memory 5.74 ⭐ 6.09 ⭐ 0.35 👎
Quality 81.97% 79.40% -2.57% 👎
Other metrics Before After Change
Lines 690 669 -21
Changed files Quality Before Quality After Quality Change
install_tech.py 82.73% ⭐ 68.23% 🙂 -14.50% 👎
ubcpdk/components.py 90.08% ⭐ 90.12% ⭐ 0.04% 👍
ubcpdk/tech.py 64.52% 🙂 65.50% 🙂 0.98% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ubcpdk/components.py ebeam_dc_halfring_straight 1 ⭐ 147 😞 15 😞 54.37% 🙂 Try splitting into smaller methods. Extract out complex expressions
install_tech.py make_link 10 🙂 132 😞 8 🙂 59.49% 🙂 Try splitting into smaller methods
ubcpdk/components.py dbr 0 ⭐ 60 ⭐ 14 😞 68.29% 🙂 Extract out complex expressions
ubcpdk/components.py add_fiber_array 0 ⭐ 44 ⭐ 10 😞 77.45% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab merged commit e1b6b41 into master Jan 1, 2023
@joamatab joamatab deleted the 111 branch January 1, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant