Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pre-commit #377

Merged
merged 1 commit into from
Apr 30, 2024
Merged

update pre-commit #377

merged 1 commit into from
Apr 30, 2024

Conversation

joamatab
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 30, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joamatab - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -83,7 +83,7 @@
},
{
"cell_type": "markdown",
"id": "6a5e26de",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Consider adding more descriptive metadata for markdown cells.

The metadata field is empty, which might be a missed opportunity to include useful information such as tags or descriptions that enhance the notebook's usability and maintainability.

Suggested change
"id": "6a5e26de",
"id": "4",
"metadata": {
"description": "Markdown cell explaining the next steps in the notebook",
"tags": ["documentation", "explanation"]
},

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.58%. Comparing base (efde015) to head (9cc5502).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   69.58%   69.58%           
=======================================
  Files          19       19           
  Lines         753      753           
=======================================
  Hits          524      524           
  Misses        229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab joamatab merged commit 492da34 into main Apr 30, 2024
8 of 9 checks passed
@joamatab joamatab deleted the fix_pre-commit branch April 30, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant