158 #39

joamatab · 2022-05-09T01:11:37Z

fix tests

sourcery-ai · 2022-05-09T01:11:45Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 2.52%.

Quality metrics	Before	After	Change
Complexity	0.50 ⭐	0.33 ⭐	-0.17 👍
Method Length	75.80 🙂	82.10 🙂	6.30 👎
Working memory	9.89 😞	8.29 🙂	-1.60 👍
Quality	71.18% 🙂	73.70% 🙂	2.52% 👍

Other metrics	Before	After	Change
Lines	463	312	-151

Changed files	Quality Before	Quality After	Quality Change
ubcpdk/components/add_fiber_array.py	68.31% 🙂	87.99% ⭐	19.68% 👍
ubcpdk/components/cells.py	63.58% 🙂	63.58% 🙂	0.00%
ubcpdk/samples/test_ubc1.py	78.11% ⭐	78.72% ⭐	0.61% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
ubcpdk/components/cells.py	ebeam_dc_halfring_straight	1 ⭐	134 😞	15 😞	55.82% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

codecov · 2022-05-09T01:11:50Z

Codecov Report

Merging #39 (02c0434) into master (ac82b0b) will decrease coverage by 2.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   56.98%   54.97%   -2.02%     
==========================================
  Files          27       27              
  Lines         637      593      -44     
==========================================
- Hits          363      326      -37     
+ Misses        274      267       -7

Impacted Files	Coverage Δ
ubcpdk/tech.py	`95.91% <ø> (ø)`
ubcpdk/components/add_fiber_array.py	`71.42% <100.00%> (-11.91%)`	⬇️
ubcpdk/components/cells.py	`64.86% <100.00%> (-0.99%)`	⬇️
ubcpdk/config.py	`98.00% <100.00%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3d1bf...02c0434. Read the comment docs.