Sometimes the wrong event types are sent to the wrong handlers

[intangir]

it seems to send to MULTIPLE handlers actually, including its correct one, but also frequently i see invalid events being sent to handlers that have nothing to do with them

heres an example (among half a dozen ive run into at least)

https://github.com/intangir/AnarchicFrontiers/blob/master/plugins/Tweak_Lobby.py#L56

comment out the line 56 there and it will error every time you drop an item
because it sends an ItemSpawnEvent to a CreatureSpawnEvent handler

maybe you can help fix it, i am not very familiar with the internals of how this mod works..

[gdude2002]

Looking into this now, I think I've found the class I want: https://github.com/gdude2002/Python-Plugin-Loader/blob/master/src/main/java/net/lahwran/bukkit/jython/PythonListener.java#L19

The code seems fairly simplistic, but I feel like the bug could be here.

[gdude2002]

When I get some time tonight, I'm going to write a simple python plugin to handle events. I've got a hunch that the reason this is happening is because of the hooks - rather than creating a Listener ourselves in the plugin.

Of course, not sure we can actually do that. But I'll look into it.

[gdude2002]

I'm almost certain that this is related to the hooks API - I'm not confident I can fix it, I'll take another look, but in the meantime would you mind rewriting one of your event handlers in the more traditional, class-based way and tell me how it goes?

[intangir]

Im actually in the process of switching my mods into java now, one ive been working on is just too complex for it to really be practical in python, need to integrate with my other mods and I dont even know how with jython

[gdude2002]

Well, the class API works the same way in java and python, and honestly
there are a bunch of things that are easier in python. Of course, though,
it's up to you what you use.
On 25 Jul 2014 10:16, "Intangir" notifications@github.com wrote:

Im actually in the process of switching my mods into java now, one ive
been working on is just too complex for it to really be practical in
python, need to integrate with my other mods and I dont even know how with
jython

—
Reply to this email directly or view it on GitHub
#1 (comment)
.

[intangir]

well you see how i wrote all of mine without classes?

i wanted to access a function from another python script but i couldn't figure it out

so i crammed several barely related functionalities into 1 huge hairy file because there was a couple shared functions

but then also its getting more complex i want to save some data and i don't really know how to do it with the python, never did figure it out

the docs were always a little bit wanting and then now that it seems like the old maintainer stopped supporting it it seems like i should just bite the bullet and convert my code into java

also with java i get compile time error checking and code completion in eclipse, starting to really miss that since im apparently mister typo in python lately

[gdude2002]

Yeah, I know how you feel. Honestly, this is jython, so you can just import
things like you would in java and it'll work. But yeah, the IDE parts are
useful.

Though I'd recommend Intellij IDEA, but whatever works for you :P
On 25 Jul 2014 17:35, "Intangir" notifications@github.com wrote:

well you see how i wrote all of mine without classes?

i wanted to access a function from another python script but i couldn't
figure it out

so i crammed several barely related functionalities into 1 huge hairy file
because there was a couple shared functions

but then also its getting more complex i want to save some data and i
don't really know how to do it with the python, never did figure it out

the docs were always a little bit wanting and then now that it seems like
the old maintainer stopped supporting it it seems like i should just bite
the bullet and convert my code into java

also with java i get compile time error checking and code completion in
eclipse, starting to really miss that since im apparently mister typo in
python lately

—
Reply to this email directly or view it on GitHub
#1 (comment)
.

[jomo]

i wanted to access a function from another python script but i couldn't figure it out

easy:

import script # script.py
script.a_function()
# or
from script import a_function
a_function()

---

code completion
mister typo

Sublime Text with the pylint plugin is working great for me.

See also: Debugging

Maybe it helps :)

[intangir]

cool jomo

i am already halfway done converting my stuff to java now though i think

and ive already tackled most of the complex parts

i think im past the point of no return

[gdude2002]

Point of "new" return indeed.

Well, I haven't gotten around to testing the differences between the two Python APIs yet - Maybe @jomo has some ideas on that?

Also, if you know Java then you should (of course) be writing Java plugins, but Python is certainly an easier option for small plugins. I don't use the Python plugin loader myself, I'm just maintaining it as people were complaining about brokenness - maybe we can get the original devs to link to our repo and CI server at some point.

[jomo]

I don't use the Python plugin loader myself, I'm just maintaining it as people were complaining about brokenness

That's awesome! ❤️

I'll try to reproduce intangir's problems with both APIs when I got some time.

[gdude2002]

I thought it'd be a good project.

Alright, thanks much, that'd be appreciated.

[jomo]

I was able to reproduce this with the decorator API, but I'm having problems with the class API.
The example class-based plugin seems to be very outdated as of Jan 17, 2012 with this commit: Bukkit/Bukkit@e35037a.

The "new" way is to use Java annotations, using @EventHandler. I don't know how to do this with jython, thus I can't test if the class API has the same problems.