Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update substrate v1.4.0 #3934

Merged
merged 23 commits into from
Jul 10, 2024
Merged

feat: Update substrate v1.4.0 #3934

merged 23 commits into from
Jul 10, 2024

Conversation

ukint-vs
Copy link
Member

@ukint-vs ukint-vs commented May 1, 2024

@ukint-vs ukint-vs added A0-pleasereview PR is ready to be reviewed by the team C1-feature Feature request C2-refactoring Refactoring proposal A5-dontmerge PR should not be merged yet labels May 1, 2024
@ukint-vs ukint-vs requested a review from ekovalev May 1, 2024 08:58
@ukint-vs ukint-vs self-assigned this May 1, 2024
@ukint-vs ukint-vs added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed and removed A0-pleasereview PR is ready to be reviewed by the team labels May 2, 2024
@breathx
Copy link
Member

breathx commented May 13, 2024

Please, rebase, cleanup and mention attached migrations in description

@ukint-vs ukint-vs added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels May 14, 2024
@ukint-vs ukint-vs force-pushed the vs/substrate-v1.4.0 branch from d775d9a to 0bf7b7c Compare May 15, 2024 12:12
@ukint-vs ukint-vs force-pushed the vs/substrate-v1.4.0 branch from 0bf7b7c to 26a04b2 Compare May 15, 2024 12:13
breathx
breathx requested changes May 16, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes just for avoiding misclick and merge
The PR requires @ekovalev's deep review

ekovalev
ekovalev approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@ekovalev ekovalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Authorship part looks cleaner than before.

breathx
breathx approved these changes May 26, 2024
View reviewed changes
runtime/vara/src/lib.rs Show resolved Hide resolved
node/authorship/src/tests.rs Show resolved Hide resolved
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels May 26, 2024
@breathx
Copy link
Member

breathx commented May 26, 2024

Well done!

Please, don't merge it atm to make sure smooth delivery. Also needs to resolve master branch conflicts and leave here a comment about CI migrations (I remember it was discussed personally, but better to post it)

@breathx
Copy link
Member

breathx commented Jul 7, 2024

Actualise branch and resolve opened discussions, please @ukint-vs

@breathx breathx removed the A5-dontmerge PR should not be merged yet label Jul 10, 2024
@breathx breathx merged commit b90deda into master Jul 10, 2024
10 checks passed
@breathx breathx deleted the vs/substrate-v1.4.0 branch July 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@ekovalev ekovalev ekovalev approved these changes

Assignees

@ukint-vs ukint-vs

Labels
A2-mergeoncegreen PR is ready to merge after CI passes C1-feature Feature request C2-refactoring Refactoring proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ukint-vs @breathx @ekovalev