chore(tooling): Use wasmer instead of wasmi #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ark0f
added
A0-pleasereview
ark0f
requested review from
ByteNacked,
clearloop and
StackOverflowExcept1on
ark0f
changed the title
breathx
approved these changes
Sep 26, 2024
|
Seems that we need to publish our fork. So we could always depend on crates btw @ark0f @clearloop |
ByteNacked
approved these changes
Sep 27, 2024
We don't need to. |
clearloop
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
the version management of wasmi is really a nightmare, could not agree more with using wasmer/wasmtime instead in no wasm required environments for reducing the workload on version managements !
btw we have the forked version wasmi gwasmi 😅 cc @breathx
StackOverflowExcept1on
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3214