Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sandbox): Use wasmer in embedded executor #4276

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

chore(sandbox): Use wasmer in embedded executor #4276

wants to merge 25 commits into from

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Oct 3, 2024 •
edited
Loading

About to replace #4267

@ark0f ark0f added the A0-pleasereview PR is ready to be reviewed by the team label Oct 3, 2024
@ark0f ark0f added D4-test Autotests, and examples E2-forcemacos Force CI to run macOS build in PR E1-forcenatwin Force CI to run native Windows build in PR E3-forcerelease Force CI to run release build in PR labels Oct 6, 2024
breathx
breathx requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be aligned as discussed

ByteNacked
ByteNacked approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@ByteNacked ByteNacked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! LGTM

gshep
gshep approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshep gshep gshep approved these changes

@ByteNacked ByteNacked ByteNacked approved these changes

@breathx breathx Awaiting requested review from breathx

@grishasobol grishasobol Awaiting requested review from grishasobol

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team D4-test Autotests, and examples E1-forcenatwin Force CI to run native Windows build in PR E2-forcemacos Force CI to run macOS build in PR E3-forcerelease Force CI to run release build in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ark0f @gshep @ByteNacked @breathx @StackOverflowExcept1on