feat(sandbox-host): update sandbox host wasmi version #4282
+832
−555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteNacked
force-pushed
the
rmasl-update-sandbox-wasmi-version
branch
from
40c5eea
to
6975f42
Compare
ByteNacked
requested review from
breathx,
gshep and
ark0f
and removed request for
breathx
|
Node sync still in progress... |
ByteNacked
added
A0-pleasereview
ByteNacked
changed the title
ark0f
reviewed
Oct 16, 2024
ByteNacked
changed the title
ark0f
requested changes
Oct 19, 2024
|
|
||
| #[derive(Debug, Clone, Copy)] | ||
| enum BorrowState { | ||
| Shared(NonZero<usize>), |
There was a problem hiding this comment.
why? type NonZeroUsize = NonZero<usize>
There was a problem hiding this comment.
Why not? I think it makes the code a little bit cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3017 .
@reviewer-or-team