feat: AST serde serialize/deserialize#1112
Merged
vobradovich merged 6 commits intomaster-idl-v2from Jan 22, 2026
Merged
Conversation
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces serde serialization and deserialization for the IDL AST, which is a great feature for interoperability. The implementation is mostly solid, using conditional compilation to make serde support optional.
I've left a few comments regarding the serde attributes:
- There's a confusing and likely incorrect use of
#[serde(untagged)]on an enum variant, which should be refactored for clarity and correctness. - There are some inconsistencies in handling empty
Vecfields during serialization. Applyingskip_serializing_if = "Vec::is_empty"uniformly would make the JSON output cleaner and more consistent.
Overall, this is a valuable addition. Addressing these points will improve the maintainability and robustness of the code.
m62624
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.