-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Introduce interface(service) id calculation #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔬 Benchmark Comparison
Legend
🤖 This comment was automatically generated by the benchmark comparison workflow at 8230830. |
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fb1e640 to
c74ea90
Compare
🔬 Benchmark Comparison
Legend
🤖 This comment was automatically generated by the benchmark comparison workflow at fd0bcc1. |
🔬 Benchmark Comparison
Legend
🤖 This comment was automatically generated by the benchmark comparison workflow at 093eca8. |
🔬 Benchmark Comparison
Legend
🤖 This comment was automatically generated by the benchmark comparison workflow at bbb1f26. |
🔬 Benchmark Comparison
Legend
🤖 This comment was automatically generated by the benchmark comparison workflow at 63b6200. |
rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_events.snap
Show resolved
Hide resolved
4314466 to
f1d21fa
Compare
ReflectHashtrait in a separate crate. It's intended to give the self-descriptive type information:deriveimpl for the trait. The trait derive also allows defining#[reflect_hash(crate = .. )]attribute which points to the trait which exports ReflectHash. That's pretty same as forparity-scale-codec.ReflectHashderive impl requires exported from the cratekeccak_const.TypeInfo)INTERFACE_IDconst inServiceMeta. The const is calculated in compile-time withkeccak256. The spec for the calculation is given in a separate file in PR.Main scope for a review:
Everything else is just consequent changes. See snap files to understand changes made to macro
service.TODO:
ReflectHashimpl