feat(idl-parser-v2): migrate to thiserror for wasm32v1-none build

[m62624]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @m62624, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the error handling within the idl-parser-v2 crate by replacing the anyhow dependency with thiserror. The change introduces a dedicated error module with custom error types, allowing for more precise and structured error propagation throughout the parser. This update aims to enhance the robustness and maintainability of the error system, particularly benefiting builds targeting wasm32v1-none.

Highlights

• Error Handling Migration: The idl-parser-v2 crate has migrated its error handling from the anyhow crate to the thiserror crate, providing more structured and type-safe error management.
• Custom Error Types: A new error.rs module was introduced to define custom error enums, Error and RuleError, which centralize error definitions for parsing and validation.
• WASM Compatibility: This migration specifically targets improved compatibility and potentially reduced overhead for wasm32v1-none target builds.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request migrates the sails-idl-parser-v2 crate from anyhow to thiserror for error handling, which is a great improvement for no_std compatibility and for a library crate in general. The changes are well-executed, introducing a new error.rs module with structured error types and replacing anyhow's conveniences with thiserror patterns.

I have a few suggestions to further improve the code:

• I've spotted a typo in an error message and its corresponding test, which should be corrected.
• I'm also proposing an enhancement to the error handling by adding a new Error::Parse variant. This will provide more precise error semantics for failures that occur when parsing values from strings, distinguishing them from parsing rule violations.