Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringEncoding: decode Unicode as 8-bit ASCII #65

Merged
merged 2 commits into from
Jan 29, 2024
Merged

StringEncoding: decode Unicode as 8-bit ASCII #65

merged 2 commits into from
Jan 29, 2024

Conversation

fialhopm
Copy link
Contributor

Follow OpenIPMI and decode StringEncodingUnicode as StringEncoding8BitAsciiLatin1. Discussed here.

@fialhopm
Copy link
Contributor Author

  1. Should this comment be updated?
  2. Is it worth adding a test case to TestFullSensorRecordDecodeFromBytes where the most significant two bits of SDR Type/Length are 00?

@gebn
Copy link
Owner

gebn commented Jan 29, 2024

  1. Should this comment be updated?

I think the comment is still valid. Implementers should indicate 0x03 rather than 0x00.

  1. Is it worth adding a test case to TestFullSensorRecordDecodeFromBytes where the most significant two bits of SDR Type/Length are 00?

Yes, we should test and verify intended behaviour of the library, independently of how up for debate that behaviour is.

@gebn gebn merged commit 09a4ddb into gebn:master Jan 29, 2024
1 check passed
@lukeyeager lukeyeager mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fialhopm @gebn