Master fix ningorg refill #283
Merged
+5
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 3, 2025 11:37
…coded ninorg content is set to init_Nmineral rather than the hardcoded value 0.2. The rest of the changes are just a revert to the original code.
fabern
approved these changes
Feb 3, 2025
|
Found it, it was here: db7b5ca
Doing it all in this PR keeps this single commit PR atomic (i.e. consistent within itself).
|
|
Hmm... I didn't understand why you have merged this without changing the Moreover, what's the relation to the other PR #284? |
|
You're right, I forgot the News. PR 284 is a proposition to fix the N
issue.
…On Tue, Feb 4, 2025, 12:21 Fabian Bernhard ***@***.***> wrote:
Hmm... I didn't understand why you have merged this without changing the
NEWS.md? If this is a bugfix than the user on v5.0.0 should understand
that there it is wrong and an update to a future 5.0.1 would fix this.
Moreover, what's the relation to the other PR #284
<#284>?
Is this here a fix and the other a feature?
—
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMC4KCZDROIRITIJTSVO432OCPDPAVCNFSM6AAAAABWMJDXOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZTGYYTCOBVGM>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undo changes made to Recover_N_balance by mistake when trying to fix the N leak. I misunderstood how the pools worked and implemented something silly which this PR is undoing.
In addition, the hardcoded ninorg content is set to init_Nmineral rather than the hardcoded value 0.2. The rest of the changes are just a revert to the original code.
Note that there is still an issue with N leaking leading to negative soil N pools, but fixing these should be treated as a separate issue (#256 ) after this PR has been merged to master to restore the original behavior.