Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for duplicate components feature? #52

Open
7ammer opened this issue Jul 20, 2015 · 2 comments
Open

Warning for duplicate components feature? #52

7ammer opened this issue Jul 20, 2015 · 2 comments

Comments

@7ammer
Copy link

7ammer commented Jul 20, 2015

Hello,
Any chance in implementing a feature to check for duplicate components.
This would help us avoid overriding existing components.

Cheers

@geddski
Copy link
Owner

geddski commented Jul 20, 2015

Not a bad idea. There is one use case though that relies on it allowing duplicates: extending components. We could make it an option, disabled by default.

@7ammer
Copy link
Author

7ammer commented Jul 20, 2015

Just read comment #38. Interesting ideas!

I'd be happy with the option you suggest :)

My thoughts were to try and find a way to prevent accidentally braking encapsulation. An alternative method to ensure encapsulation could be to add an option to generate a random suffix id at the end of the component selector ie .selector-ID43F6 but then that makes things hard to use in other places for example selecting in javascript with querySelector(). It would also brake your method for extending again ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants