Prevent from releasing empty version numbers #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When incrementing version number, both semver 1.4.x and 2.0.10 returns a _null_ value if something went wrong. As far as I know, the two main cases leading to a _null_ resulting version are either a bad initial version number, or a bad release type (e.g. _majour_). This patch just makes grunt-release check the resulting version number (either after a bump or not) for non nullness and throw a grunt warning if the test fails. Another solution would have been to add many sanity checks before starting the release task like checking that the provided release type has expected value (major, minor, patch, etc) but it appears it is more flexible to just let the _semver_ library to do the hard work for us and simply check for non nullness of the resulting version.
|
This is a good start. It probably should do a |
|
Great commit message! It just landed in 2ab471e. Thanks and cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When incrementing version number, both semver 1.4.x and 2.0.10 returns a
null value if something went wrong.
As far as I know, the two main cases leading to a null resulting
version are either a bad initial version number, or a bad release type
(e.g. majour).
This patch just makes grunt-release check the resulting version number
(either after a bump or not) for non nullness and throw a grunt warning
if the test fails.
Another solution would have been to add many sanity checks before
starting the release task like checking that the provided release type
has expected value (major, minor, patch, etc) but it appears it is more
flexible to just let the semver library to do the hard work for us and
simply check for non nullness of the resulting version.