Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiline commit messages #42

Closed
wants to merge 1 commit into from
Closed

Added support for multiline commit messages #42

wants to merge 1 commit into from

Conversation

niclashoyer
Copy link
Contributor

I ran into an issue with multiline git commit messages. I wanted to add [ci skip] to a release commit. I tried setting

release.options.commitMessage = 'Release <%= version %>\n\n[ci skip]';

which indeed printed out the following in verbose mode

Running: git commit package.json -m "Release 0.0.2-5

[ci skip]"

but it seems that shelljs.exec has problems with multiline commands, as the execution just hangs and never completes, which also causes timeouts on travis builds. It may be a bug in shelljs, but an answer on StackOverflow also stated that it is much better to use the -m flag instead of newlines.

So I added the ability to pass an array to commitMessage where each element will be parsed as an argument to git commit with the -m flag which sets multiline commit messages accordingly (even on windows).

@drublic
Copy link
Collaborator

drublic commented Dec 3, 2014

Thanks for the PR. It landed in 5c10148.

@drublic drublic closed this Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants