Fix imagePullSecrets properly this time

geek-cookbook · May 25, 2020 · 06cb2a1 · 06cb2a1
1 parent 83c0ad7
commit 06cb2a1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/charts/webhook-receiver/Chart.yaml b/charts/webhook-receiver/Chart.yaml
@@ -6,7 +6,7 @@ type: application
 
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 1.0.3
+version: 1.0.4
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application.

diff --git a/charts/webhook-receiver/templates/deployment.yaml b/charts/webhook-receiver/templates/deployment.yaml
@@ -14,10 +14,8 @@ spec:
       labels:
         {{- include "webhook-receiver.selectorLabels" . | nindent 8 }}
     spec:
-    {{- with .Values.imagePullSecrets }}
       imagePullSecrets:
-        {{- toYaml . | nindent 8 }}
-    {{- end }}
+      - name: {{ .Values.imagePullSecret }}
       serviceAccountName: {{ include "webhook-receiver.serviceAccountName" . }}
       securityContext:
         {{- toYaml .Values.podSecurityContext | nindent 8 }}

diff --git a/charts/webhook-receiver/values.yaml b/charts/webhook-receiver/values.yaml
@@ -9,9 +9,8 @@ image:
   tag: 2.7.0
   pullPolicy: IfNotPresent
 
-imagePullSecrets: 
-  - webhook-receiver-pullsecret
-
+imagePullSecrets: webhook-receiver-pullsecret
+
 nameOverride: ""
 fullnameOverride: ""