Allow to use different type of probes #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the earlier approach, where the default values activated the
httpGet
probe type, it was not possible to use another probe liketcpSocket
.Right now it's on your own to decide how to define your probes. As this is changing the probes by default this means this is a breaking change.
Description
Probes are disabled by default, example is provided in the
values.yaml
file instead.Motivation and Context
I saw that with the previous version I wasn't able to disable the
httpGet
probe, even trying to put it tonull
in the subchart where I'm using this chart.How Has This Been Tested?
Already tested in production
Types of changes
Checklist