Skip to content

Allow to use different type of probes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bvis
Copy link
Contributor

@bvis bvis commented Feb 13, 2023

With the earlier approach, where the default values activated the httpGet probe type, it was not possible to use another probe like tcpSocket.

Right now it's on your own to decide how to define your probes. As this is changing the probes by default this means this is a breaking change.

Description

Probes are disabled by default, example is provided in the values.yaml file instead.

Motivation and Context

I saw that with the previous version I wasn't able to disable the httpGetprobe, even trying to put it to null in the subchart where I'm using this chart.

How Has This Been Tested?

Already tested in production

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contribution guide
  • The format of my change matches that of existing code/documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant