fix bug: qianfan_api.py _achat_completion_stream add request_timeout #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v0.8-release #1442 +/- ##
================================================
- Coverage 82.40% 82.21% -0.20%
================================================
Files 249 245 -4
Lines 13839 13689 -150
================================================
- Hits 11404 11254 -150
Misses 2435 2435 ☔ View full report in Codecov by Sentry. |
iorisa
reviewed
Aug 21, 2024
| @@ -117,7 +117,7 @@ async def acompletion(self, messages: list[dict], timeout: int = USE_CONFIG_TIME | |||
| return await self._achat_completion(messages, timeout=self.get_timeout(timeout)) | |||
|
|
|||
| async def _achat_completion_stream(self, messages: list[dict], timeout: int = USE_CONFIG_TIMEOUT) -> str: | |||
| resp = await self.aclient.ado(**self._const_kwargs(messages=messages, stream=True)) | |||
| resp = await self.aclient.ado(**self._const_kwargs(messages=messages, stream=True),request_timeout = timeout) | |||
There was a problem hiding this comment.
Add the same code on lines 107 and 112， like #1460
geekan
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug: qianfan_api.py _achat_completion_stream add request_timeout