Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bedrock): Temporary AWS credentials via env vars + supported models update #1450

Merged
merged 9 commits into from
Oct 20, 2024

Conversation

JGalego
Copy link
Contributor

@JGalego JGalego commented Aug 17, 2024

Features

Example

  1. Add MetaGPT config
llm:
  api_type: 'bedrock'
  model: "amazon.titan-text-premier-v1:0"
  # 🔔 No need to add the access_key or secret_key!
  1. Configure AWS Credentials
export AWS_ACCESS_KEY_ID=...
export AWS_SECRET_ACCESS_KEY=...
export AWS_SESSION_TOKEN=...
export AWS_DEFAULT_REGION=us-east-1
  1. Call MetaGPT
metagpt "Create a 2048 game"

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.93023% with 34 lines in your changes missing coverage. Please review.

Project coverage is 62.50%. Comparing base (ab846f6) to head (47be4f5).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
metagpt/provider/bedrock/bedrock_provider.py 14.70% 29 Missing ⚠️
metagpt/provider/bedrock_api.py 33.33% 4 Missing ⚠️
metagpt/provider/bedrock/utils.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   62.59%   62.50%   -0.09%     
==========================================
  Files         287      287              
  Lines       17589    17622      +33     
==========================================
+ Hits        11009    11015       +6     
- Misses       6580     6607      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JGalego JGalego marked this pull request as ready for review August 17, 2024 03:15
@JGalego JGalego changed the title feat(bedrock): Temporary AWS credentials support via env vars + supported models update feat(bedrock): Temporary AWS credentials via env vars + supported models update Aug 17, 2024
@JGalego
Copy link
Contributor Author

JGalego commented Aug 20, 2024

@usamimeri @Wei-Jianan as authors of Bedrock-related PRs, would you mind reviewing these changes? cc: @geekan

metagpt/provider/bedrock/utils.py Show resolved Hide resolved
metagpt/provider/bedrock_api.py Show resolved Hide resolved
metagpt/provider/bedrock/bedrock_provider.py Show resolved Hide resolved
metagpt/provider/bedrock/utils.py Outdated Show resolved Hide resolved
@better629
Copy link
Collaborator

lgtm

Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekan geekan merged commit 8f34c74 into geekan:main Oct 20, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants