fix #687 #1500
Merged
fix #687 #1500
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenchucheng
had a problem deploying
to
unittest
GitHub Actions
Failure
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
+ Coverage 61.99% 62.65% +0.65%
==========================================
Files 285 285
Lines 17534 17535 +1
==========================================
+ Hits 10871 10986 +115
+ Misses 6663 6549 -114 ☔ View full report in Codecov by Sentry. |
geekan
approved these changes
Oct 11, 2024
shenchucheng
had a problem deploying
to
pre-commit
GitHub Actions
Failure
shenchucheng
had a problem deploying
to
unittest
GitHub Actions
Failure
shenchucheng
had a problem deploying
to
pre-commit
GitHub Actions
Failure
|
Pre-commit seems to be down? |
shenchucheng
force-pushed
the
fix-serialize-error
branch
from
4fa0e3f to
61bb774
Compare
shenchucheng
temporarily deployed
to
pre-commit
GitHub Actions
Inactive
shenchucheng
had a problem deploying
to
unittest
GitHub Actions
Failure
shenchucheng
temporarily deployed
to
pre-commit
GitHub Actions
Inactive
I have enabled Pre-commit and force-pushed the changes again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Because the Method class cannot be serialized, simply exclude fields of type Method from WebBrowserEngine and SearchEngine. This ensures that the serialization process does not encounter errors related to the Method class, addressing issue #687.
Result
You can verify this by running: