Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French README and Fix Incorrect URL Redirections #1503

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

TitanSage02
Copy link
Contributor

Features

  • Added French README: Created a French version of the README file to improve accessibility for French-speaking users.

  • Updated links to include French version: Modified existing documents to add links to the French version of the README.

  • Bugfix: Resolved incorrect URL redirections: Fixed issues with incorrect redirections (see issue Bug: Unable to Navigate Back to Main README from README_CN or README_JA #1502) to ensure smooth navigation across different language versions.

  • Related Documentation: Updated documents to include the correct links to README_FR.

Impact

  • Main Impact: Enhanced user experience by providing accessible documentation in French and fixing redirection issues. This update facilitates multilingual navigation.
  • Compatibility: Backward-compatible update with previous versions of the documents.

Results

  • Tests and Results: Navigation tests between different language versions were conducted, and the corrected links function properly.

  • Additional Notes: This update is a step towards better internationalization of the documentation. Additional language versions may be considered in the future.

1
2
3

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.65%. Comparing base (45f102c) to head (8a792fb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1503   +/-   ##
=======================================
  Coverage   62.65%   62.65%           
=======================================
  Files         285      285           
  Lines       17535    17535           
=======================================
  Hits        10986    10986           
  Misses       6549     6549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geekan
Copy link
Owner

geekan commented Oct 20, 2024

Thank you very much for your contribution. I noticed that this will involve other READMEs. Can you modify it together?

@TitanSage02
Copy link
Contributor Author

Thank you for pointing that out. I've already made the necessary updates to the other READMEs. Let me know if there are any further adjustments needed.

Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, they are simple and clean

@geekan geekan merged commit 8b209d4 into geekan:main Oct 22, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants