Skip to content

Add collapsible property #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 3, 2025
Merged

Add collapsible property #42

merged 7 commits into from
Jun 3, 2025

Conversation

berge472
Copy link
Contributor

Allows user to make some parents non-collapsible

@geekhybrid geekhybrid self-requested a review April 23, 2025 17:22
@geekhybrid
Copy link
Owner

Looks good. @berge472

However, what do you think about piggybacking on the disabled property?

So, a disabled node cannot be expanded or collapsed, nor can it be dragged or dropped upon?

@berge472
Copy link
Contributor Author

With disabled the items arent able to be checked/selected. I think their are use cases where we would want the ability to select and item that is not collapsible.

@geekhybrid
Copy link
Owner

That makes sense. Can you look at why the tests are failing ? I can have a look if you don't find the time.

@berge472
Copy link
Contributor Author

The Node Version for the test container just needed to be updated. Should be good now

@geekhybrid
Copy link
Owner

Great work @berge472

@geekhybrid
Copy link
Owner

Let's updated the README and I'll merge this. Thanks

@berge472
Copy link
Contributor Author

berge472 commented Jun 3, 2025

The README has already been updated

@geekhybrid geekhybrid merged commit b1592c6 into geekhybrid:main Jun 3, 2025
1 check passed
@berge472
Copy link
Contributor Author

berge472 commented Jun 4, 2025

Can you update the npm release with this?

@geekhybrid
Copy link
Owner

Sure, new version will be available in a few hours.

@geekhybrid
Copy link
Owner

Can you update the npm release with this?

@berge472 Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants