Feature: Support Muliple Languages #93 #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for geeksblabla ready! Built with commit 438c4e2 |
ridaeh
changed the title
ans1genie
reviewed
Oct 23, 2021
| @@ -0,0 +1,29 @@ | |||
| // the translations | |||
| // (tip move them in a JSON file and import them) | |||
There was a problem hiding this comment.
I like the idea to move it into separate files (json, yaml, properties..).
worth add a sub-section "translate" in the readme.md ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue #93 , I propose this MR to support multilingual in the Geeksblabla website.
The translation is not yet completed, I just want to ensure that you approve the modification before going deep .
You can try to access your
localhostfor english as default or/fr/for the french language.Ps: Only the landing page is translated for now.