Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added daemon.json configuration and custom CA #108

Closed
wants to merge 5 commits into from

Conversation

dev-rowbot
Copy link

These changes will allow the user to configure the daemon.json file during the install as well as add custom Certificate Authorities.

@dev-rowbot
Copy link
Author

After committing these changes I see there is an existing PR for the daemon.json changes - #92
I am happy to remove my changes since they look almost exactly the same.

@varac
Copy link

varac commented Jun 12, 2019

@geerlingguy @dev-rowbot What's the state of the PR ? Would be nice to get it merged.

@dev-rowbot
Copy link
Author

@varac from my side I was not planning any further changes unless required

@stale
Copy link

stale bot commented Mar 6, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Mar 6, 2020
@stale
Copy link

stale bot commented Mar 6, 2020

This pull request is no longer marked for closure.

@stale stale bot removed the stale label Mar 6, 2020
@dev-rowbot
Copy link
Author

@geerlingguy I've cleaned up all the lint failures and pull in the latest branch.

If you feel this would add value please feel free to merge.

@linuxbandit
Copy link

This addresses issue #90, and there are other PRs addressing it: #190, #140, #108
(just wanted to make some order, hopefully one of the three will be picked. Trying to help with issue maintenance)

@stale
Copy link

stale bot commented Jul 18, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Jul 18, 2020
@stale
Copy link

stale bot commented Aug 17, 2020

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants