Skip to content

Conversation

@leifmadsen
Copy link
Contributor

This resolves issue #20

@Ahmed
Copy link

Ahmed commented Jul 14, 2016

I was like wtf, why he is not using a template?

Also adds default variables so that you can more easily override the
values from your own wrapper playbook.
@leifmadsen leifmadsen force-pushed the use_templates_not_lineinfile branch from 9155b78 to 0b2cd79 Compare July 14, 2016 14:19
@leifmadsen
Copy link
Contributor Author

@Ahmed well, it makes sense when the configuration file could change / add more values etc, so the lineinfile option makes sense since it keeps things a little more intact / version agnostic.

I personally have just found writing the regex and and such to be a little more effort than it's worth, especially when the template is relatively short.

@geerlingguy
Copy link
Owner

I was like wtf, why he is not using a template?

I often use lineinfile if I need to change < 5 variables in a template, for a few reasons:

  1. I can use the system packaged default template (which varies by OS and version somewhat, usually)
  2. I don't have to maintain a monolithic template that is now used across all OSes and versions
  3. There's a lot less Ansible configuration involved (see the diff here).

That said, I do switch to including and copying a template when the situation warrants it... and it may here. It looks like it at least works across all the main supported OSes with the current ES version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants