Better handling of the service in stopped state #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevented waiting for Elasticsearch when `elasticsearch_service_state` is set to `stopped`. * Avoided triggering 'restart elasticsearch' handler under the same condition. Reasoning: Encountered a need to configure security features mandatory for Elasticsearch 8.x. Initial attempts to configure pre-installation were unsuccessful, as these settings require Elasticsearch to be installed first. Thus, opted for post-installation configuration. This necessitated the ability to install and configure Elasticsearch without starting the service. Note: Security settings required by default in Elasticsearch 8.x ideally should be incorporated into the role itself. Plan to explore adding this support to the existing role when possible.
|
Hi, would you like to accept and merge this PR please ? |
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
|
Hi, would you like to accept and merge this PR please ? |
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
|
Ping? 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elasticsearch_service_stateis set tostopped.Reasoning:
Encountered a need to configure security features mandatory for Elasticsearch 8.x. Initial attempts to configure pre-installation were unsuccessful, as these settings require Elasticsearch to be installed first. Thus, opted for post-installation configuration. This necessitated the ability to install and configure Elasticsearch without starting the service.
Note:
Security settings required by default in Elasticsearch 8.x ideally should be incorporated into the role itself. Plan to explore adding this support to the existing role when possible.