Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

.gitignore errors in latest version #1411

Closed
inversed opened this issue Jun 5, 2017 · 4 comments
Closed

.gitignore errors in latest version #1411

inversed opened this issue Jun 5, 2017 · 4 comments
Labels

Comments

@inversed
Copy link

inversed commented Jun 5, 2017

Issue Type

  • Bug Report / Support Request

Your Environment

NOTE: I'm running ansible through the GUEST via the force_ansible_local: true setting.

Vagrant 1.9.2
VirtualBox 5.1.18r114002
bash: ansible: command not found

Your OS

  • Windows (10)

Full console output

https://gist.github.com/inversed/b469c0e64709b2828f95b735a81aa8b4

Summary

Drupal-VM's .gitignore excludes a required file (provisioning/tasks/config.yml).
When trying to do a vagrant up on a project where Drupal-VM itself has been included in a repo, that file (and tests/config.yml) is missing so the spin up operation fails.

This might not be the intended use case (docs specify running this Windows 10's Bash) but this approach does work fine. Seems like this is a minor bug that's easy to fix but I don't know if it's actually an intentional configuration issue.

oxyc added a commit to oxyc/drupal-vm that referenced this issue Jun 6, 2017
@geerlingguy
Copy link
Owner

Technically this is how I originally intended it to work, but I see your point. For applications like BLT, the box/config.yml is explicitly committed (e.g. git commit -f box/config.yml) and then it's part of the repository.

But it should probably only be excluded in the root directory (for testing or using Drupal VM completely standalone), not in subdirectories.

It looks like @oxyc is working on a fix already 😀

@oxyc
Copy link
Collaborator

oxyc commented Jun 6, 2017

Just trying to find the git version when leading / was added 😄

oxyc added a commit to oxyc/drupal-vm that referenced this issue Jun 6, 2017
@inversed
Copy link
Author

inversed commented Jun 8, 2017

Thanks for the update and great tool, BTW!

geerlingguy added a commit that referenced this issue Jun 28, 2017
Issue #1411: Fix gitignore applying rules to files in subdirectories
@geerlingguy
Copy link
Owner

That change has been merged in, so it will be part of the next minor release... which I hope to push out this week (was going for the weekend, but life got in the way, so it'll be sometime this week).

ashabed pushed a commit to debugacademy/academyvm that referenced this issue Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants