Expanded Local Dev config example #157
Conversation
|
@shawnachieve - Could you actually make these changes directly to the normal |
|
I've merged my separate example.config.yml file in to the base example.config.yml file. |
|
FYI, it looks like using the apache_mods_enabled directive is having some unintended side effects. When that directive is used to enable mod_expires it seems that it drops several of the default mods that are suppose to be enabled by the apache ansible script (e.g. enabling mod_expires removes mod_ssl and mod_rewrite). I'm investigating this further and will update the PR as soon as I figure out what's going on. |
| - rewrite.load | ||
| # apache_mods_disabled: [] | ||
|
|
||
| # Enable SSL Support on the Drupal site vhosts. |
There was a problem hiding this comment.
Can you file a separate PR for the SSL vhosts (and remove it from this PR)? I want to make sure that this works correctly across different OSes and provides a seamless experience out of the box, and I'd rather tackle that separately.
|
@shawnachieve - Can you also split out the xdebug changes? Thinking about this further, I'd like to have some more time to do some performance comparison with the defaults before/after, and it might be a case where we add some extra documentation, but don't actually change the defaults (except to add some things that people might want to change when they enable xdebug). |
|
@shawnachieve - Actually, scratch that—as I'm working on cleaning up some documentation, I decided to also merge in the changes to So, please remove those changes from this PR, and I think it'll be good to go for a merge! |
| @@ -64,11 +64,25 @@ configure_local_drush_aliases: true | |||
|
|
|||
| # Apache VirtualHosts. Add one for each site you are running inside the VM. For | |||
| # multisite deployments, you can point multiple servernames at one documentroot. | |||
| # NOTE: We create separate vhosts for www and non-www URLs so that the | |||
| # hostsupdater plugin will create host file entries for both. | |||
| # NOTE: We can't create a vhost with a servername of "www.{{ drupal_domain }}" | |||
There was a problem hiding this comment.
Unfortunately, this breaks some of the intuitive behavior of the config.yml file, since now users will have to change the domain in multiple places.
For now, I'd be okay with users having to manually add in www. for the domain, and I'd like to make it so hostsupdater can get all the domains even if they use variables like {{ varname }}.
…ed_example Conflicts: example.config.yml
…ngs and remove the www vhost entry.
|
Synced the PR with master and removed the www vhost entry. Now the PR just contains the apache modules code. |
PR #157: Add apache mods config so extra mods are loaded.
|
Thanks! |
This PR provides a new example.config.yml file that demonstrates how to configure the VM with the following features:
The above are basically the changes I find myself making to the default config.yml file every time I spin up a new VM. So I'm hoping that adding a new example.config.yml file will help out other people that may want these features.