This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
Update php.md #1617
Merged
Update php.md #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're correct that it links to the wrong URL but it should be to https://github.com/geerlingguy/ansible-role-php#readme and not to drupal-vm's readme. Could you update the PR and i'll merge it. |
oxyc
reviewed
Jan 16, 2018
docs/configurations/php.md
Outdated
| @@ -19,4 +19,4 @@ Remi's RPM repository is included with Drupal VM, and you can make the following | |||
|
|
|||
| If you want parity with your production environment and wish to install the default distribution packages, set `php_version: ''` inside your `config.yml` to avoid adding Remi's or Ondřej's repositories. Doing this will use the default packages set in the [`geerlingguy.php`](https://github.com/geerlingguy/ansible-role-php) Ansible role. | |||
|
|
|||
| _Note: If you're using a base OS with a PHP version older than what's assumed in the `geerlingguy.php` role, you will also need to override some of the default variables set by that role in your `config.yml`. See the [`geerlingguy.php` Ansible role's README](https://github.com/geerlingguy/drupal-vm/blob/master/provisioning/README.md) for more information._ | |||
| _Note: If you're using a base OS with a PHP version older than what's assumed in the `geerlingguy.php` role, you will also need to override some of the default variables set by that role in your `config.yml`. See the [`geerlingguy.php` Ansible role's README]( https://github.com/geerlingguy/ansible-role-php#readme) for more information._ | |||
There was a problem hiding this comment.
You accidentally added a space before the URL
README]( https..
^
There was a problem hiding this comment.
Not my day today! :)
|
Thanks for cleaning up my mistakes when adding those docs! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.