Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Check for post_provisioning_scripts being defined before attempting t… #426

Merged
merged 1 commit into from
Feb 12, 2016

Conversation

mminklet
Copy link
Contributor

…o run them

Was getting this error before this check
file or module does not exist: /Users/Mike/drupalvm/provisioning/post_provision_scripts

@geerlingguy
Copy link
Owner

If you have post_provision_scripts: [] inside config.yml, this task doesn't fail, it just skips due to the list being empty (see: https://github.com/geerlingguy/drupal-vm/blob/master/example.config.yml#L215-L218)

In this case, if upgrading from an older version of Drupal VM, you should run a diff of your older config.yml with the example.config.yml to make sure any new vars are added in. It's not ideal, and I might find a better way to deal with this problem (adding new variables) soon, but it is what it is for now and if I add a conditional for one new variable I'd have to do it for all of them :(

@geerlingguy geerlingguy reopened this Feb 12, 2016
@geerlingguy
Copy link
Owner

I'll keep this open for now, per discussion in #425 — as "MINOR version when you add functionality in a backwards-compatible manner, and" would mean a 2.X.x release shouldn't break 2.X-1.x code/config... :(

geerlingguy added a commit that referenced this pull request Feb 12, 2016
Check for post_provisioning_scripts being defined before attempting t…
@geerlingguy geerlingguy merged commit 92ae6d5 into geerlingguy:master Feb 12, 2016
@geerlingguy geerlingguy added this to the 2.3.0 milestone Feb 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants